gbmusic: Setting to disable double/triple press control, remove touch controls setting, reduce fadeout flicker #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firmware 2v10 will disable touch/swipe while the LCD is off anyway. (Next commit will just remove this setting altogether, but just in case)
Firmware 2v10 will disable touch/swipe while the LCD is off anyway, so just enable them always. (but keeps the check that the LCD is on until the whole world has upgraded their firmware)
For music players which handle multiple button presses themselves. see http://forum.espruino.com/comments/15984222/
|
Nice - thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2v10will ignore touch/swipe events while the LCD is off anyway, so just having a setting to disable them seems silly.(we still check the LCD is off before handling touch events, as probably not everybody is using
2v10yet ;-)