Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SPI (fix #1963) #1964

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Update SPI (fix #1963) #1964

merged 2 commits into from
Dec 4, 2020

Conversation

MaBecker
Copy link
Contributor

@MaBecker MaBecker commented Dec 4, 2020

  • each SPI get's its onw dma channel
  • disable DMA by setting the bus initialization to 0

@MaBecker
Update SPI (fix #1963)
a133b57 
* each SPI get's its onw dma channel
* disable DMA by setting the bus initialization to 0
@gfwilliams
Copy link
Member

What about disabling DMA just if rx is specified? So you get it fast when it can be...

ret=spi_device_queue_trans(SPIChannels[channelPnt].spi, &spi_trans, rx?0:portMAX_DELAY);

@MaBecker
Update SPI (fix #1963)
1245529 
* disabling DMA just if rx is specified
@MaBecker
Copy link
Contributor Author

MaBecker commented Dec 4, 2020

ups, missed that one ;-)

@gfwilliams
Copy link
Member

Thanks! And this seems to work ok for you now?

@MaBecker
Copy link
Contributor Author

MaBecker commented Dec 4, 2020

Thanks! And this seems to work ok for you now?

yes it does - thanks a lot :)

@gfwilliams gfwilliams merged commit 3604727 into master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaBecker @gfwilliams