Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more callbacks for incoming data from the emulator #63

Merged
merged 2 commits into from
May 9, 2024

Conversation

halemmerich
Copy link
Contributor

Needed for full functionality of espruino/BangleApps#3399

@gfwilliams gfwilliams marked this pull request as ready for review May 9, 2024 13:59
@gfwilliams
Copy link
Member

Thanks - just merged and added comments. Looks like you could have used the rxCallback but you'd have had to have split the lines up

@gfwilliams gfwilliams merged commit e892f68 into espruino:master May 9, 2024
1 check passed
@halemmerich
Copy link
Contributor Author

runapptests.js actually uses the consoleOutputCallback to suppress the output for full lines when the interactive console is active since then every single character is output from the rxCallback. That would otherwise double the emulator output in the terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants