Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the scripts for GRG #678

Closed
21 tasks done
topowright-zz opened this issue Jul 16, 2018 · 12 comments
Closed
21 tasks done

Update the scripts for GRG #678

topowright-zz opened this issue Jul 16, 2018 · 12 comments

Comments

@topowright-zz
Copy link
Contributor

topowright-zz commented Jul 16, 2018

Background:

Currently the geoprocessing tools released inside of Military Tools for ArcGIS 3.0 have updates and bug fixes that have not been updated in this repo

Current Scenario

We have tools that are managed in multiple locations that are not in sync

Expected Results

Update the scripts for GRG updated with the changes made in Military Tools for ArcGIS 3.0

Tasks to be done 16 July 2018

GRG Solution

Clearing Ops

Clearing Operations:

  • Create the Final aptx (this is done manually by the team)

  • update Defense Whats new for Clearing Ops @bbooth

  • update August 2018 release topic (cms)

  • Updates the contents page for Clearing Operations in CMS @bbooth

  • Remove the comments made about the widget in the overview (time and speed) @bbooth
    - [ ] Create a topic that would have a generic approach that would be used for settign up all desktop like solutions. @bbooth

@csmoore
Copy link
Member

csmoore commented Jul 17, 2018

Just copying the files from the Military Tools repo seems to work fine, the only end-user difference using these files is the Military Tools version has an extra toolset that was not in the original version so I just wanted to make sure this is OK or this toolset should be removed:

New Version (from Military Tools):

image

Original Version:

image

Update: the working branch with the changes I made to move over the latest available is at: https://github.com/Esri/solutions-geoprocessing-toolbox/tree/csm/%23678-update-grg-with-latest

@dfoll
Copy link
Collaborator

dfoll commented Jul 18, 2018

can someone clarify what the name convention will be? The screenshot above has "GriddedReferenceGraphicTools.pyt" matching our naming convention from Military Tools, it should be "Gridded Reference Graphic.pyt"

@ACueva
Copy link
Contributor

ACueva commented Jul 19, 2018

Marking task "Update the try it live update if needed" completed. The Try-it-Live (TIL) was originally created on May 15, 2018. I cross referenced issues that were completed after this TIL was published. I verified these issues do not occur in our current TIL and that the previously reported bugs are not present. This tells me the back end code is being updated automatically.
The potential issue Mike Miller was warning us against is if we introduce new functionality and set the functionality to "on" by default. Existing applications will have this functionality turned on automatically once the push is made.

@lfunkhouser
Copy link
Member

Updated the original description to cross out the task, "Update the try it live since no work was done." The work was completed in Verify the try it live is the most to update widget. The Try It application did not require an update based on #678 (comment).

@ACueva ACueva removed their assignment Jul 19, 2018
@ACueva
Copy link
Contributor

ACueva commented Jul 19, 2018

Removed my assignment from:
Verify CMS Workflows updates
Verify Solutions website

These issues cannot be worked on currently as the workflow topics are still in copy editing. @dfoll has reached out to the doc team and verified the doc team is not waiting on anything from us.

@BobBooth BobBooth self-assigned this Jul 20, 2018
@BobBooth
Copy link
Contributor

Have a PR in for the Clearing Operations homepage update:
https://github.com/ArcGIS/arcgis-solutions-website/pull/6753

@BobBooth
Copy link
Contributor

Homepage updates complete, once merged. Removing my assignment and moving to Sprint 1.

@BobBooth BobBooth removed their assignment Jul 20, 2018
@dfoll
Copy link
Collaborator

dfoll commented Jul 23, 2018

  • There is a task in the issue body to add Number Features to the .pyt, can this be marked off?
  • Should the August 2018 release of GRG include text that Number Features is included now? We added that to MT for June, but in the context of GRG, the August release includes it now
  • There is a task in the body of this issue to remove Clearing Operations.pyt, if we have the complete toolbox in Military Tools Geoprocessing Toolbox (MTGT), when can we remove Clearing Operations.pyt from SGT?

@topowright-zz
Copy link
Contributor Author

PR #679 addresses the top three issues in the tasks to be done.

@topowright-zz topowright-zz self-assigned this Jul 24, 2018
@BobBooth
Copy link
Contributor

I checked in the two topics I discussed in Scrum under reused-topics. "Set up Defense solutions" is my second try, and seems to cover most of the cases. "Set up the solution" was the first try, and only covers a minority of the cases.
@dfoll @topowright @ACueva - feel free to have a look and think about Set up Defense solutions topic as an option.
image.png

@BobBooth
Copy link
Contributor

August 2018 release notes page for Clearing Operations on SolutionssDev says:
"...
August 2018 release notes
The Clearing Operations August 2018 release supports the following:

ArcMap 10.3.1-10.6.1
ArcGIS Pro 2.1–2.2
..."
Before I check that task off as done, are we agreed that this is all it needs to say?
@dfoll @topowright @ACueva
Any note about changing the toolbox name, bug fixes, etc?

@dfoll
Copy link
Collaborator

dfoll commented Jul 25, 2018

my opinion is no bug fixes listed, because we did not make any bug fixes to the clearing operations solution. what I do think we should list is that we now use the GRG toolbox instead of the clearing operations toolbox. @topowright and I were trying to get that work finished but were experiencing some issues we need to continue digging into, before we do that, so the text has not been added yet. my opinion is leave it unchecked and we will check it off when what is happening with the toolbox is sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants