Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate codesign logic from electron builder for macOS #2050

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

itsmesamster
Copy link
Collaborator

No description provided.

@AmmarAbouZor
Copy link
Member

These changes should be included in the build CLI tool as following:

  • Release Command should have an argument code-sign that should provide the path for the signing configuration file.
  • Configuration file should include all possible paths and command + Anything that can be changed often to avoid direct changes on Build CLI code.
  • Configuration file format can be anything serialized with serde. It would be nice to have it in JSON format.
  • Changes can be push directly to this PR
  • Program should fail if this argument is provided on Linux or Windows

@AmmarAbouZor AmmarAbouZor self-assigned this Sep 9, 2024
@AmmarAbouZor
Copy link
Member

Hi @itsmesamster @DmitryAstafyev,
I've implemented the code signing and notarizing for MacOS as following:

  • I've added the CLI argument --code-sign or -c which accept the path for the configuration file of code signing.
  • The implementation of code signing is a part of release on MacOS now when the configuration file & Environment variables are provided.
  • The configuration file is in toml format because we can add comments to it unlike json format.
  • I've included all paths, commands and environment variables in the configuration file and created a configuration file with the current configurations talken from rake implementation under the path cli/codesign_config/macos.toml. The file is well documented to explain the meaning of those configurations
  • An example for running the code signing:
cargo chipmunk release -c cli/codesign_config/macos.toml

@DmitryAstafyev
Copy link
Collaborator

@AmmarAbouZor thanks for PR. A couple of moments:

  • as soon as application/holder/hooks/afterSign.js isn't used - makes sense to remove it.
  • please also make with @itsmesamster tests with failed signing process to make sure we have in output relevant error messages. For example, put into credentials some error, like APPLEIDPASS = FAKEPASS.

itsmesamster and others added 2 commits September 17, 2024 14:38
* Provide CLI argument for code sign configuration & Include it in
  release for Mac OS.
* Implement code signing and Notarizing for MacOS
* Code sign will be done with configuration files in `toml` format
  because it allows writing comments.
* Provide a configuration file with the current configuration from rake
  implementation.
* Remove not needed parts from MacOS release to match the changes on
  rake solution on this PR
@DmitryAstafyev DmitryAstafyev merged commit 88a8893 into esrlabs:master Sep 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants