Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #4 #5 : change examples folder hierarchy and README. #6

Merged
merged 2 commits into from
Apr 9, 2019

Conversation

helbashandy
Copy link
Contributor

No description provided.

code/java/essdive.java Outdated Show resolved Hide resolved
@@ -6,19 +6,26 @@ The ESS-DIVE Package service allows you to submit JSON-LD data package metadata

Provide feedback on the package service to ess-dive-support@lbl.gov.

### Repository folder hierarchy:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to each of the folders from this hierarchy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use bullet points. This format hurts my eyes.

code/r/config.r Outdated Show resolved Hide resolved
code/python/setup.py Outdated Show resolved Hide resolved
Copy link
Member

@vchendrix vchendrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all commited *.pyc files

@helbashandy helbashandy force-pushed the issue_4_adjust_structure branch 3 times, most recently from 9caf1a8 to d0e8b0f Compare April 5, 2019 11:00
closes #4: add links to readme and change api to sandbox
Copy link
Member

@vchendrix vchendrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just one further change!

@@ -6,19 +6,26 @@ The ESS-DIVE Package service allows you to submit JSON-LD data package metadata

Provide feedback on the package service to ess-dive-support@lbl.gov.

### Repository folder hierarchy:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use bullet points. This format hurts my eyes.

@helbashandy helbashandy merged commit 78f7678 into master Apr 9, 2019
@vchendrix vchendrix deleted the issue_4_adjust_structure branch June 28, 2019 15:41
@vchendrix vchendrix added the ESS-DIVE All ESS-DIVE Tasks label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ESS-DIVE All ESS-DIVE Tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants