Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Guzzle client #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mattjmattj
Copy link

Add guzzlehttp/guzzle as composer suggestion and provide a
client based on it.

Nothing fancy here, but hopefully the first step toward asynchronous requests in essence/essence

Add guzzlehttp/guzzle as composer suggestion and provide a
client based on it.
@mattjmattj
Copy link
Author

Whoops. Travis tests fail because Guzzle is only a suggestion, not a dependency. Maybe should I had it as a require-dev dependency

new unit tests break the build because guzzle was
only a suggestion
@felixgirault
Copy link
Member

Thank you!
Though I think the Essence\Http\Client interface should live in the main repo...
This way we could create a new repo with your code, and the user could choose what client to use.

@felixgirault felixgirault self-assigned this Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants