Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base in kustomize install instuctions #63

Merged
merged 3 commits into from
Mar 11, 2020
Merged

Fix base in kustomize install instuctions #63

merged 3 commits into from
Mar 11, 2020

Conversation

JohnPaton
Copy link
Contributor

Fixes #62

@JohnPaton
Copy link
Contributor Author

Pinging @JorritSalverda 🙂

@JohnPaton
Copy link
Contributor Author

What is the check that hasn't completed here?

@JorritSalverda
Copy link
Collaborator

Unfortunately we don't run builds for PRs from forks yet since this poses a security threat since the .estafette.yaml manifest used for defining the build steps can be modified. So the PR seems to be waiting for a build that's never going to happen. Since it's just a textual update I'll merge anyway, and in the mean time contemplate how we're going to provide PR builds in a safe way.

@JorritSalverda JorritSalverda merged commit 11c4df5 into estafette:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorritSalverda JorritSalverda JorritSalverda approved these changes

@etiennetremel etiennetremel etiennetremel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong base in kustomize install instructions
3 participants
@JohnPaton @JorritSalverda @etiennetremel