Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ability to pass imageTagMutability via config #678

Merged
merged 4 commits into from
Feb 27, 2024
Merged

fix: ability to pass imageTagMutability via config #678

merged 4 commits into from
Feb 27, 2024

Conversation

estahn
Copy link
Owner

@estahn estahn commented Feb 27, 2024

fixes #649

@estahn estahn self-assigned this Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 34.77%. Comparing base (910dafc) to head (f856c8b).
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/registry/ecr.go 13.33% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
+ Coverage   34.59%   34.77%   +0.18%     
==========================================
  Files           9        9              
  Lines         688      693       +5     
==========================================
+ Hits          238      241       +3     
- Misses        425      427       +2     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@estahn estahn merged commit 71ddf71 into main Feb 27, 2024
13 of 14 checks passed
@estahn estahn deleted the fix-649 branch February 27, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ecrOptions.imageTagMutability doesn't work
1 participant