Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecrOptions.imageTagMutability doesn't work #649

Closed
mikebryant opened this issue Jan 29, 2024 · 1 comment · Fixed by #678
Closed

ecrOptions.imageTagMutability doesn't work #649

mikebryant opened this issue Jan 29, 2024 · 1 comment · Fixed by #678
Labels
bug Something isn't working

Comments

@mikebryant
Copy link

We've set this to IMMUTABLE, but it's still created as MUTABLE

It's configurable here:

k8s-image-swapper/pkg/config/config.go

Line 82 in 369ac7c

ImageTagMutability string `yaml:"imageTagMutability"`

But hardcoded here:

k8s-image-swapper/pkg/registry/ecr.go

Line 114 in 369ac7c

ImageTagMutability: aws.String(ecr.ImageTagMutabilityMutable),

@estahn
Copy link
Owner

estahn commented Jan 30, 2024

@mikebryant Good find. Would you mind contributing a PR for this?

@estahn estahn added the bug Something isn't working label Jan 30, 2024
estahn added a commit that referenced this issue Feb 27, 2024
@estahn
fix: ability to pass imageTagMutability via config
4039d12 
fixes #649
@estahn estahn mentioned this issue Feb 27, 2024
Merged
estahn added a commit that referenced this issue Feb 27, 2024
@estahn
fix: ability to pass imageTagMutability via config (#678)
71ddf71 
fixes #649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ability to pass imageTagMutability via config estahn/k8s-image-swapper
2 participants
@estahn @mikebryant