Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Universal favicon #742

Closed
1 task
steida opened this issue Feb 26, 2016 · 5 comments
Closed
1 task

Universal favicon #742

steida opened this issue Feb 26, 2016 · 5 comments

Comments

@steida
Copy link
Contributor

steida commented Feb 26, 2016

Este should have universal favicon generator as gulp task. Hopefully, there is something like realfavicongenerator in npm.

  • npm favicon generator for all Este supported platforms
@robinpokorny
Copy link
Contributor

There exists gulp-real-favicon which is a wrapper to rfg-api whitch itself is a wrapper over RealFaviconGenerator API.

The problem is that then the build process would take several seconds later and it would be depending on a 3rd party service.

Hopefully someone finds a better solution.

@steida
Copy link
Contributor Author

steida commented Feb 26, 2016

Building favicon is so rare that it doesn't have to be part of app build.

cbioley added a commit to cbioley/este that referenced this issue Apr 26, 2016
Add the following Gulp tasks:

- generate-favicon: generate icons based on what's configured in the task definition
- inject-favicon: craft what will be injected into head tag
- favicon: do both operations sequentially

Close este#742
cbioley added a commit to cbioley/este that referenced this issue Apr 26, 2016
Add the following Gulp tasks:

- generate-favicon: generate icons based on what's configured in the task definition
- inject-favicon: craft what will be injected into head tag
- favicon: do both operations sequentially

Close este#742
cbioley added a commit that referenced this issue May 6, 2016
Add the following Gulp tasks:

- generate-favicon: generate icons based on what's configured in the task definition
- inject-favicon: craft what will be injected into head tag
- favicon: do both operations sequentially

Close #742
@cbioley
Copy link
Contributor

cbioley commented May 6, 2016

@steida Just pushed an updated version of an "old" PR. It's effectively creating icons via RealFaviconGenerator service.

It's indeed dependent on an external service, but as long as it works, why not using it? ;)

@steida
Copy link
Contributor Author

steida commented May 7, 2016

That's nothing wrong with external service : ) Thank you! Will review it soon.

cbioley added a commit to cbioley/este that referenced this issue May 12, 2016
Add the following Gulp tasks:

- generate-favicon: generate icons based on what's configured in the task definition
- inject-favicon: craft what will be injected into head tag
- favicon: do both operations sequentially

Close este#742
@steida steida added the blocked label May 16, 2016
@steida
Copy link
Contributor Author

steida commented May 16, 2016

Blocked by #874

cbioley added a commit to cbioley/este that referenced this issue May 19, 2016
Add the following Gulp tasks:

- favicon-generate: generate icons based on what's configured in the task definition
- favicon-inject: craft what will be injected into head tag
- favicon: do both operations sequentially

Close este#742
cbioley added a commit to cbioley/este that referenced this issue May 19, 2016
Add the following Gulp tasks:

- favicon-generate: generate icons based on what's configured in the task definition
- favicon-inject: craft what will be injected into head tag
- favicon: do both operations sequentially

Close este#742
cbioley added a commit to cbioley/este that referenced this issue May 19, 2016
Add the following Gulp tasks:

- favicon-generate: generate icons based on what's configured in the task definition
- favicon-inject: craft what will be injected into head tag
- favicon: do both operations sequentially

Close este#742
cbioley added a commit that referenced this issue May 19, 2016
Add the following Gulp tasks:

- favicon-generate: generate icons based on what's configured in the task definition
- favicon-inject: craft what will be injected into head tag
- favicon: do both operations sequentially

Close #742
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants