Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move To Evenement 2.0 #2

Closed
estelsmith opened this issue Jan 5, 2014 · 0 comments
Closed

Move To Evenement 2.0 #2

estelsmith opened this issue Jan 5, 2014 · 0 comments
Assignees

Comments

@estelsmith
Copy link
Owner

It would be nice to move to Evenement 2.0 and utilize traits, so that instantiating the router itself is simplified, and not requiring a dependency to be fulfilled.

// Bad.
$emitter = new EventEmitter();
$router = new BaseRouter($emitter);

// Better!!
$router = new BaseRouter();
@ghost ghost assigned estelsmith Jan 5, 2014
estelsmith added a commit that referenced this issue Jan 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant