Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigBuilder::build can now consume config #176

Closed

Conversation

SarthakSingh31
Copy link

@estk
Copy link
Owner

estk commented Dec 16, 2020

I'm sorry its taken so long for me to get to this.
I think the api could use some refinement, in theory i agree this should exist though.
For instance I wish that the config builder included the root so that you could just call .build on it but I'm not sure the consequences this would have. I have hesitated to respond before doing all the investigation but I just have not had time. Perhaps you can do some investigation and we can chat about other solutions. Sorry for the incomplete answer :/

@estk estk added the WIP Work In Progress label Dec 16, 2020
@estk
Copy link
Owner

estk commented Apr 30, 2022

closing stale

@estk estk closed this Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants