Implement colored output in console logger. #5
Conversation
This implementation is based on the prototype provided by @ryantaylor in estk#3. Adds a new color syntax to the pattern parser which looks like this: %c:color(...colored text...) Also changes the default pattern to `%c:highlight(%d %l %t -) %m`. closes estk#3
|
I chose to use the You can run the test crate to take a quick look at suggested default highlighter. |
| //! When logging to console, color codes can be used to display text in different colors. | ||
| //! | ||
| //! The basic syntax looks like this: | ||
| //! `%c:{color}(...)` , where {color} is one of the following: |
There was a problem hiding this comment.
It seems like it would make more sense to use {} instead of () to stay in line with %d formats?
|
Thanks for the suggestions, will take a closer look later. |
|
Oh, and with respect to simplifying parsing, I want to rewrite the parser in terms of nom or LALRPOP instead of hand-rolling it. It seems unfortunate to have the syntax we pick be decided on the level of difficulty involved in updating the parser :) Maybe I'll tackle that tonight. |
|
Very good idea, i was also thinking about this earlier. I will clean up the colorization logic but leave the parsing to you then ;) |
|
I'm going to close this out as it's a bit out of date. I'd still very much like to have coloration support, though! |
This implementation is based on the prototype provided by @ryantaylor in #3.
Adds a new color syntax to the pattern parser which looks like this:
%c:color(...colored text...)Also changes the default pattern to
%c:highlight(%d %l %t -) %m.closes #3