add support for optional chaining #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
acornjs/acorn#891 merged, will back to this PR this weekend |
|
Updated this PR |
|
@michaelficarra should we support node@4 in travis? I added I can remove node@4 from travis.yml and add node@10 instead |
|
Ok. I removed Node 4 is few years as deprecated, so I think it's the time to leave this version |
|
@michaelficarra also i created PR to the So it is best to merge |
|
Any news? |
|
Any ETA when this PR can be reviewed? |
|
Hi guys! This PR is very important for me and many people in the world! Please, merge it |
|
I upvote for fast merge |
|
@Constellation Hi. Can you check and merge this? |
|
@michaelficarra re-ping |
1 similar comment
|
@michaelficarra re-ping |
|
i support this re-ping |
|
@michaelficarra please, re-check this. It is REALLY hard to contribute to this project because of a lack of maintenance. It kills all motivation to contribute here. |
|
@michaelficarra re-ping |
1 similar comment
|
@michaelficarra re-ping |
|
@michaelficarra ping |
|
|
|
@michaelficarra ping |
|
@michaelficarra please check this. More than a month I'm waiting for your approval. |
|
@michaelficarra it is insulting the feelings of contributors! |
added 15 commits
August 5, 2020 21:45
sanex3339
force-pushed
the
optional-chaining-support
branch
from
4cce5f8
to
f672353
Compare
@michaelficarra done |
added 2 commits
August 5, 2020 23:46
…xpression callee without arguments
…ion callee without arguments
michaelficarra
approved these changes
Aug 5, 2020
michaelficarra
changed the title
|
Published v2.0.0 (since I got yelled at last time I dropped support for an ancient node version in a minor release). |
|
Thank you! |
sanex3339
added a commit
to javascript-obfuscator/escodegen
that referenced
this pull request
Aug 14, 2020
Co-authored-by: sanex3339 <yarabotayuvyandex3339>
brettz9
added a commit
to brettz9/escodegen
that referenced
this pull request
Feb 9, 2021
Merge branch 'eslint-npm' into eslint-npm-full * eslint-npm: - npm: update estraverse - npm: update devDeps. - npm: Update package-lock version - npm: update devDeps. - npm: Update package-lock version - Linting: Temporarily disable most linting, with a few fixes - Breaking change: Remove bower-registry-client build (bower deprecated) - Update: Use new SourceMapConsumer API in test - Build: Provide browserified builds with npm package - Travis: Drop 4, 6, 8; Add 10, 12, 14; check build - Maintenance: Add `.editorconfig` - Docs: Use fenced code blocks in README (for syntax highlighting) - npm: Add `bugs`, `keywords`, change from `maintainers` to `authors`/`contributors` - npm: Restore `optionator` to a regular dep. (used in published binary file) - npm: Drop unused semver, minimist - npm: Bump deps. (estraverse, optionator, optional source-map potentially breaking) and devDeps. - npm: Drop bluebird in favor of ES Promises - npm: Use more recently maintained browserify + uglifyify - npm: Replace linting and testing scripts in Gulpfile with npm scripts Add more optional-chaining tests Test logical assignments Implement coalescing code generation Support BigInt syntax Update gulpfile and dependencies Version 2.0.0 add support for optional chaining (estools#412) Update .gitattributes drop support for node <6 (estools#419) # Conflicts: # .eslintignore # .eslintrc.js # .gitignore # escodegen.js.map # package-lock.json # package.json # src/escodegen.js # test/source-map.js # tools/release.js
brettz9
added a commit
to brettz9/escodegen
that referenced
this pull request
Feb 9, 2021
Merge branch 'eslint-npm' into eslint-npm-full; also fixes regression (line 959) introduced in cf9a7b8 * eslint-npm: - npm: update estraverse - npm: update devDeps. - npm: Update package-lock version - npm: update devDeps. - npm: Update package-lock version - Linting: Temporarily disable most linting, with a few fixes - Breaking change: Remove bower-registry-client build (bower deprecated) - Update: Use new SourceMapConsumer API in test - Build: Provide browserified builds with npm package - Travis: Drop 4, 6, 8; Add 10, 12, 14; check build - Maintenance: Add `.editorconfig` - Docs: Use fenced code blocks in README (for syntax highlighting) - npm: Add `bugs`, `keywords`, change from `maintainers` to `authors`/`contributors` - npm: Restore `optionator` to a regular dep. (used in published binary file) - npm: Drop unused semver, minimist - npm: Bump deps. (estraverse, optionator, optional source-map potentially breaking) and devDeps. - npm: Drop bluebird in favor of ES Promises - npm: Use more recently maintained browserify + uglifyify - npm: Replace linting and testing scripts in Gulpfile with npm scripts Add more optional-chaining tests Test logical assignments Implement coalescing code generation Support BigInt syntax Update gulpfile and dependencies Version 2.0.0 add support for optional chaining (estools#412) Update .gitattributes drop support for node <6 (estools#419) # Conflicts: # .eslintignore # .eslintrc.js # .gitignore # escodegen.js.map # package-lock.json # package.json # src/escodegen.js # test/source-map.js # tools/release.js
brettz9
added a commit
to brettz9/escodegen
that referenced
this pull request
Feb 9, 2021
Merge branch 'eslint-npm' into eslint-npm-full; also adds linting to recent adds and fixes regression (line 959) introduced in cf9a7b8 * eslint-npm: - npm: update estraverse - npm: update devDeps. - npm: Update package-lock version - npm: update devDeps. - npm: Update package-lock version - Linting: Temporarily disable most linting, with a few fixes - Breaking change: Remove bower-registry-client build (bower deprecated) - Update: Use new SourceMapConsumer API in test - Build: Provide browserified builds with npm package - Travis: Drop 4, 6, 8; Add 10, 12, 14; check build - Maintenance: Add `.editorconfig` - Docs: Use fenced code blocks in README (for syntax highlighting) - npm: Add `bugs`, `keywords`, change from `maintainers` to `authors`/`contributors` - npm: Restore `optionator` to a regular dep. (used in published binary file) - npm: Drop unused semver, minimist - npm: Bump deps. (estraverse, optionator, optional source-map potentially breaking) and devDeps. - npm: Drop bluebird in favor of ES Promises - npm: Use more recently maintained browserify + uglifyify - npm: Replace linting and testing scripts in Gulpfile with npm scripts Add more optional-chaining tests Test logical assignments Implement coalescing code generation Support BigInt syntax Update gulpfile and dependencies Version 2.0.0 add support for optional chaining (estools#412) Update .gitattributes drop support for node <6 (estools#419) # Conflicts: # .eslintignore # .eslintrc.js # .gitignore # escodegen.js.map # package-lock.json # package.json # src/escodegen.js # test/source-map.js # tools/release.js
brettz9
added a commit
to brettz9/escodegen
that referenced
this pull request
Feb 9, 2021
…recent adds and fixes regression (line 959) introduced in cf9a7b8 * eslint-npm: - npm: update estraverse - npm: update devDeps. - npm: Update package-lock version - npm: update devDeps. - npm: Update package-lock version - Linting: Temporarily disable most linting, with a few fixes - Breaking change: Remove bower-registry-client build (bower deprecated) - Update: Use new SourceMapConsumer API in test - Build: Provide browserified builds with npm package - Travis: Drop 4, 6, 8; Add 10, 12, 14; check build - Maintenance: Add `.editorconfig` - Docs: Use fenced code blocks in README (for syntax highlighting) - npm: Add `bugs`, `keywords`, change from `maintainers` to `authors`/`contributors` - npm: Restore `optionator` to a regular dep. (used in published binary file) - npm: Drop unused semver, minimist - npm: Bump deps. (estraverse, optionator, optional source-map potentially breaking) and devDeps. - npm: Drop bluebird in favor of ES Promises - npm: Use more recently maintained browserify + uglifyify - npm: Replace linting and testing scripts in Gulpfile with npm scripts Add more optional-chaining tests Test logical assignments Implement coalescing code generation Support BigInt syntax Update gulpfile and dependencies Version 2.0.0 add support for optional chaining (estools#412) Update .gitattributes drop support for node <6 (estools#419) # Conflicts: # .eslintignore # .eslintrc.js # .gitignore # escodegen.js.map # package-lock.json # package.json # src/escodegen.js # test/source-map.js # tools/release.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec:
https://github.com/estree/estree/pull/204/files