ArrowExpression vs ArrowFunctionExpression

[sebmck]

Currently both esprima and acorn use ArrowFunctionExpression.

• arrowExpression vs ArrowFunctionExpression jquery/esprima#1013
• https://code.google.com/p/esprima/issues/detail?id=567
• https://bugzilla.mozilla.org/show_bug.cgi?id=913617

[jeffmo]

Esprima intends to switch to ArrowExpression in its next major release

[ariya]

...unless, per Mozilla bug 913617 above, Mozilla really executes the plan to switch from ArrowExpression to ArrowFunctionExpression.

An alternative would be to use ArrowFunction, the term used in the ES 6 grammar.

[sebmck]

How about just keeping ArrowFunctionExpression?

[ariya]

I am for staying with ArrowFunctionExpression, I still think that's the most descriptive name. But that depends if SpiderMonkey is going to change Reflect.parse or not. IIRC this didn't happen (yet) because there are other Mozilla tooling relying on ArrowFunction.

[mikesherov]

@dherman, care to fill us in on plans here?

[dherman]

I'll have to ask around. I'm not sure how much tooling would have to change but I wouldn't imagine it's too bad. I'll report back.

[ariya]

@dherman Any data points on the tooling change effort?

[dherman]

Looks like it shouldn't be a problem for Mozilla at all. I built https://github.com/dherman/samo and grepped the addons ecosystem and found zero uses of Reflect.parse. I searched mxr for uses in the FF front-end and there are very few. So it should be pretty easy for us to make incompatible changes.

[sebmck]

Closed via 321c836.

[dherman]

For reference I've submitted a SpiderMonkey patch for feedback: https://bugzilla.mozilla.org/show_bug.cgi?id=913617#c2

[dherman]

My fix to SpiderMonkey landed so hopefully by tomorrow Firefox Nightlies will have ArrowFunctionExpression.

https://bugzilla.mozilla.org/show_bug.cgi?id=913617#c13

[RReverser]

Cool! I guess we can merge #45 now?