Add ES2022 normative change #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
changed the title
JLHwung
reviewed
Dec 25, 2021
es2022.md
Outdated
| @@ -83,6 +83,33 @@ extend interface BinaryExpression <: Expression { | |||
| - `left` can be a private identifier (e.g. `#foo`) when `operator` is `"in"`. | |||
| - See [Ergonomic brand checks for Private Fields][proposal-private-fields-in-in] for details. | |||
|
|
|||
| # Modules | |||
|
|
|||
| See https://github.com/tc39/ecma262/pull/2154 for more details. | |||
There was a problem hiding this comment.
Nit: Consider provide a text link instead of url, for example, [Arbitrary module namespace identifier names].
JLHwung
reviewed
Dec 25, 2021
| extend interface ImportSpecifier <: ModuleSpecifier { | ||
| imported: Identifier | Literal; | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Consider add a note for further restrictions:
If
importedis aLiteral,imported.valuemust be a string without lone surrogate.
JLHwung
approved these changes
Dec 26, 2021
nzakas
approved these changes
Dec 28, 2021
|
|
||
| If `imported` is a `Literal`, `imported.value` must be a string without lone surrogate. | ||
|
|
||
| ## Exports |
There was a problem hiding this comment.
Should ExportAllDeclaration also be extended?
export * as "foo" from "mod"There was a problem hiding this comment.
Thanks! a22ea89
13 tasks
JLHwung
approved these changes
Jan 1, 2022
RReverser
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tc39/ecma262#2154 has been merged to ECMAScript. It will be included in ES2022.
So we should add it to estree spec.
Fixes #270