Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Arbitrary module namespace identifier names #2154

Merged
merged 1 commit into from Nov 10, 2021

Conversation

bmeck
Copy link
Member

@bmeck bmeck commented Aug 26, 2020

I do not believe this affects any integration downstream.

This PR aims to allow:

import {"\0 any unicode" as foo} from "";
export {foo as "\0 any unicode"};

This matches the restriction that WASM has that the string names for exports must be valid Unicode.

Depends on #2155

@bmeck bmeck added needs consensus This needs committee consensus before it can be eligible to be merged. needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 normative change Affects behavior required to correctly evaluate some ECMAScript source text labels Aug 26, 2020
@ljharb ljharb changed the title Arbitrary module namespace identifier names Normative: Arbitrary module namespace identifier names Aug 26, 2020
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
ljharb pushed a commit to ljharb/ecma262 that referenced this pull request Aug 26, 2020
This was extracted from tc39#2154 so it could land separately.
ljharb pushed a commit to ljharb/ecma262 that referenced this pull request Aug 26, 2020
This was extracted from tc39#2154 so it could land separately.
spec.html Outdated
1. Let _env_ be the running execution context's LexicalEnvironment.
1. Perform ? InitializeBoundName(*"\*default\*"*, _value_, _env_).
1. Perform ? InitializeBoundName(~default~, _value_, _env_).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InitializeBoundName only accepts strings

ljharb pushed a commit to ljharb/ecma262 that referenced this pull request Aug 26, 2020
This was extracted from tc39#2154 so it could land separately.
ljharb pushed a commit to ljharb/ecma262 that referenced this pull request Aug 26, 2020
This was extracted from tc39#2154 so it could land separately.
ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 26, 2020
This was extracted from tc39#2154 so it could land separately.

Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 2, 2020
This was extracted from tc39#2154 so it could land separately.

Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 2, 2020
This was extracted from tc39#2154 so it could land separately.

Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 2, 2020
This was extracted from tc39#2154 so it could land separately.

Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 2, 2020
This was extracted from tc39#2154 so it could land separately.

Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 8, 2020
This was extracted from tc39#2154 so it could land separately.

Co-authored-by: Jordan Harband <ljharb@gmail.com>
@bmeck
Copy link
Member Author

bmeck commented Sep 11, 2020

Updated, now depends on #2155

spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
@ljharb ljharb added has consensus This has committee consensus. and removed needs consensus This needs committee consensus before it can be eligible to be merged. labels Sep 21, 2020
spec.html Outdated Show resolved Hide resolved
@JLHwung
Copy link

JLHwung commented Sep 21, 2020

Should we allow { ModuleExportName as ModuleExportName } in ExportFromtClause?

The goal example

import {"\0 any unicode" as foo} from "";
export {foo as "\0 any unicode"};

reminds me of the following one-liner:

export {"\0 any unicode" as "\0 any unicode"} from "some-module";

@ExE-Boss
Copy link
Contributor

It should also be possible to do:

export { "\0 any unicode" } from "some-module";

@bakkot
Copy link
Contributor

bakkot commented Nov 10, 2021

Sorry for the delay on getting this landed, all!

@aladdin-add aladdin-add mentioned this pull request Mar 31, 2022
6 tasks
sxzz added a commit to vuejs/core that referenced this pull request Dec 29, 2022
sxzz added a commit to vuejs/core that referenced this pull request Jan 26, 2023
sxzz added a commit to vuejs/core that referenced this pull request Feb 1, 2023
sxzz added a commit to vuejs/core that referenced this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has consensus This has committee consensus. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet