Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working with Server-Relative URLs #8

Open
jimmywim opened this issue Jul 31, 2020 · 0 comments
Open

Working with Server-Relative URLs #8

jimmywim opened this issue Jul 31, 2020 · 0 comments

Comments

@jimmywim
Copy link

I've noticed this breaks when you try to navigate to a server relative url (/sites/somesite/sitepages/page.aspx), but it works fine with absolute URLs.

Is there a trick to getting it to work with server relative URLs, other than checking for a / at the start and then sticking on window.location.origin?
diabhoil added a commit to diabhoil/spfx-navigation that referenced this issue Oct 18, 2021
@diabhoil
Change for server relative urls
4eed236 
I am not sure what the old line should do, but with server relative URLs that was not working. Adding a double slash in front of sites or /sites breaks the URL for SPO.

Refering to issue estruyf#8
@diabhoil diabhoil mentioned this issue Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimmywim