Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol/capture: remove tail #830

Merged
merged 1 commit into from
Dec 7, 2022
Merged

protocol/capture: remove tail #830

merged 1 commit into from
Dec 7, 2022

Conversation

mdibaiee
Copy link
Member

@mdibaiee mdibaiee commented Dec 6, 2022

Description:

  • Remove tail from capture protocol
  • Remove the --poll option from temp-data-plane and consumer

Workflow steps:

N/A as connectors have already been migrated to not use this option anymore.

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

@mdibaiee mdibaiee force-pushed the mahdi/remove-tail branch 2 times, most recently from abf2105 to e614141 Compare December 6, 2022 14:09
@mdibaiee mdibaiee marked this pull request as ready for review December 6, 2022 15:12
@mdibaiee mdibaiee requested review from jgraettinger, psFried and willdonnelly and removed request for jgraettinger December 6, 2022 15:13
Copy link
Member

@willdonnelly willdonnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdibaiee mdibaiee merged commit f70e7b4 into master Dec 7, 2022
@mdibaiee mdibaiee deleted the mahdi/remove-tail branch December 7, 2022 12:06
@oliviamiannone oliviamiannone added the docs complete / NA No (more) doc work related to this PR label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs complete / NA No (more) doc work related to this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants