Skip to content

Commit

Permalink
I don't think specifying a sorting param is necessary for these tests
Browse files Browse the repository at this point in the history
...but I could be wrong. Maybe this is worth a pull request?
  • Loading branch information
Max Edmands committed Dec 28, 2013
1 parent 107138b commit 3fe231c
Showing 1 changed file with 4 additions and 14 deletions.
18 changes: 4 additions & 14 deletions test/tableParamsSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,7 @@ describe('ngTableParams', function () {
}));

it('ngTableParams test settings', inject(function (ngTableParams) {
var params = new ngTableParams({
'sorting[name]': 'asc'
});
var params = new ngTableParams();

expect(params.settings()).toEqual({
$scope: null,
Expand All @@ -150,11 +148,7 @@ describe('ngTableParams', function () {
getGroups: params.getGroups
});

params = new ngTableParams({
'sorting[name]': 'asc'
}, {
total: 100
});
params = new ngTableParams({}, { total: 100 });

expect(params.settings()).toEqual({
$scope: null,
Expand All @@ -167,9 +161,7 @@ describe('ngTableParams', function () {
}));

it('ngTableParams test getData', inject(function ($q, ngTableParams) {
var params = new ngTableParams({
'sorting[name]': 'asc'
});
var params = new ngTableParams();
$defer = $q.defer();
$defer.promise.then(function(data) {
expect(data).toEqual([]);
Expand All @@ -178,9 +170,7 @@ describe('ngTableParams', function () {
}));

it('ngTableParams test grouping', inject(function ($q, ngTableParams) {
var params = new ngTableParams({
'sorting[name]': 'asc'
});
var params = new ngTableParams();
params.getData = function ($defer) {
$defer.resolve(data);
};
Expand Down

0 comments on commit 3fe231c

Please sign in to comment.