-
Notifications
You must be signed in to change notification settings - Fork 851
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(header): header-class attribute is now a data binding expression
Previously the header-class attribute was added to a th element as a string literal. Now the header-class attribute is supplied as a binding expression which has access to the column definition. This is a start in a move toward a design where TD element attributes are expressions that have access to the scope. BREAKING CHANGE: Previously, a css class was added to TH elements thusly: ```` <tr ng-repeat="row in $data"> <td header-class="myHeaderClass"></td> </tr> ```` Now: ```` <tr ng-repeat="row in $data"> <td header-class="'myHeaderClass'"></td> </tr> ````
- Loading branch information
1 parent
df3f070
commit 60de206
Showing
3 changed files
with
16 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60de206
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Much needed :)
60de206
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid having to add the quotes I did a regular find-replace on all my HTML using ng-table
Find: header-class="(.*?)"
Replace: header-class="'$1'"
I am using eclipse, do not know if this kind of find-replace is commonly available in other IDE's
Just worth mentioning in case it can save someone a bit of time