Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng-table not working correctly when Yeoman project is exported #418

Closed
tomcashman opened this issue Sep 12, 2014 · 3 comments
Closed

ng-table not working correctly when Yeoman project is exported #418

tomcashman opened this issue Sep 12, 2014 · 3 comments

Comments

@tomcashman
Copy link

I generated a project through Yeoman and its angular generator. I then added a bower dependency on ng-table and added it to the app.js as a module dependency. I set up a view based on the sortable table example and ran 'grunt serve' and everything works as expected in the browser.

But, when I export the web app by running 'grunt', the output in the 'dist' folder results with the ng-table directive not working correctly. (I view the output of the project using 'python -m SimpleHTTPServer')

I suspect this might be to do with the usemin or ngAnnotate Grunt tasks that are used.

I've uploaded an example of the issue to this repository -> ng-table-yeoman-issue

@tomcashman
Copy link
Author

Seems to be sorting that is effected, pagination works fine.

tomcashman added a commit to tomcashman/ng-table that referenced this issue Sep 15, 2014
It seems htmlmin removes the sortable properties in the html. Fixed
this by changing the tag from sortable to data-sortable.
@creimers
Copy link

creimers commented Oct 8, 2014

I was experiencing the same thing, and also changing the attribute sortable to data-sortable indeed solve the issue.

@jpk1215
Copy link

jpk1215 commented Jan 20, 2015

I can confirm that @creimers attribute name changed worked for me when deploying using grunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants