Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue when compiling with Google Closure compiler #148

Merged
merged 1 commit into from
Dec 28, 2013
Merged

Fix issue when compiling with Google Closure compiler #148

merged 1 commit into from
Dec 28, 2013

Conversation

supergillis
Copy link
Contributor

When compiling ng-table with Google's closure compiler, the code would not paginate. The while loop below the declaration of i was converted to a for loop. After declaring i as variable and recompiling, ng-table works as expected.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8814c6e on supergillis:patch-1 into 107138b on esvit:master.

esvit added a commit that referenced this pull request Dec 28, 2013
@esvit
Merge pull request #148 from supergillis/patch-1
de37467 
Fix issue when compiling with Google Closure compiler
@esvit esvit merged commit de37467 into esvit:master Dec 28, 2013
@supergillis supergillis deleted the patch-1 branch December 28, 2013 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@supergillis @coveralls @esvit