Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'filter-data' to accept function/array/object variables #342

Closed
wants to merge 1 commit into from

Conversation

etodanik
Copy link

This comes very useful when dealing with autocomplete inputs that need to pull data from the server. For instance, the following example deals with twitter's typeahead.

We define a new template:

$templateCache.put('ng-table/filters/typeahead.html', '<input type="text" class="sfTypeahead filter filter-typeahead" name="{{column.filterName}}" options="{highlight: true}" datasets="column.data" ng-model="params.filter()[name]">');

In this case, filter.data would have had to look like this, to be able to pull stuff from the server:

{
    displayKey: 'val',
    source: workplaces.ttAdapter()
}

This pull request allows for that without prohibiting the usual way of doing things.

@gunta
Copy link

gunta commented Jun 20, 2014

+1

@etodanik
Copy link
Author

Any response from the @esvit?

@mfauveau
Copy link

+1 @esvit where are you?

@esvit
Copy link
Owner

esvit commented Jul 16, 2014

Hi guys, sorry for not having replied, very many requests. Do not have time to view all of this week will find the time to see everything.

@lukad
Copy link

lukad commented Jan 14, 2015

+1

@iyeldinov
Copy link
Collaborator

please provide an example where it will suite

@etodanik
Copy link
Author

I provided a valid use case (used in a production app of mine) and an example in the pull request comments

@iyeldinov iyeldinov added this to the v0.4.3 milestone Jan 18, 2015
@iyeldinov iyeldinov closed this Jan 18, 2015
@avneeshroks
Copy link

Hey Guys, can anyone please help me solving my problem related to filter-data update i have mentioned over here - #186 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants