Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit the class attribute when generating the table header's column. #77

Merged
merged 1 commit into from
Sep 27, 2013

Conversation

killfill
Copy link
Contributor

Hi,

Was using ng-table and noticed that the td's class attribute are not getting read when generating the td's headers. For example:

< table ng-table.... >
< tr..>
< td >
< td class='visible-sm>
< /tr>
< /table>

If the visible-sm class contains "display: none", it will hide the column data.
I wanted to hide the column header too.

Hope you can do something like this, and bump a new bower version soon.. :)

Thanks!!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 866d62c on killfill:header-column-inherit-class into 64105a3 on esvit:master.

esvit added a commit that referenced this pull request Sep 27, 2013
Inherit the class attribute when generating the table header's column.
@esvit esvit merged commit 197e771 into esvit:master Sep 27, 2013
@killfill killfill deleted the header-column-inherit-class branch September 27, 2013 12:16
@ricochet1k
Copy link

This doesn't seem to be working for me. I'm seeing a literal "column.class" as part of the class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants