Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable sortable Paramater #82

Merged
merged 5 commits into from
Oct 2, 2013
Merged

Conversation

inkitt
Copy link
Contributor

@inkitt inkitt commented Oct 1, 2013

This PR allows the sortable parameter to be a variable. It uses the same 'concept' for the variable title parameter to make sortable also variable.

This is needed for cases when you have a very flexible table whose column values are changeable.

// Code
$scope.variableColumn = 'name';

// HTML
    <table ng-table="tableParams" class="table">
        <tr ng-repeat="user in users">
            <td data-title="variableColumn">
                {{user[variableColumn]}}
            </td>
            <td sortable="'age'">
                {{user.age}}
            </td>
        </tr>
    </table>

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2fbe898 on AliAlbazaz:variable-sortable-param into fc7716a on esvit:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4f0e50f on AliAlbazaz:variable-sortable-param into fc7716a on esvit:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d266206 on AliAlbazaz:variable-sortable-param into fc7716a on esvit:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d266206 on AliAlbazaz:variable-sortable-param into fc7716a on esvit:master.

@esvit esvit merged commit d266206 into esvit:master Oct 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants