Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(add): accept dev-flag to install as devDependency #980

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

lessp
Copy link
Contributor

@lessp lessp commented Oct 8, 2019

Unfortunately I couldn't get the tests to run. But seems to be working when using the local binary!

... Also guessing, I'll need to handle the sandbox etc.

Eventually closes #978

@lessp
Copy link
Contributor Author

lessp commented Oct 9, 2019

So, this seems to work locally but the tests are failing. 😄

Admittedly, I haven't really had the time to completely dig in to the whole flow, so I might definitely be missing something! 🤷‍♂

@andreypopp
Copy link
Member

Thanks!

So, this seems to work locally but the tests are failing. 😄

Tests seem to pass on CI.

@andreypopp
Copy link
Member

Tests seem to pass on CI.

I apologise. Looking into that.

@smorimoto
Copy link
Contributor

Any updates on this?

@lessp
Copy link
Contributor Author

lessp commented Nov 28, 2019

Any updates on this?

I haven't got any time to finish this currently, unfortunately. It looked like it was working locally, but the tests did not pass. Don't know enough to know what's missing. Do you want to take a stab at it @imbsky ? Perhaps @andreypopp can give some pointers

@smorimoto
Copy link
Contributor

I don't have much time too, but maybe I can take this when I have time.

@smorimoto
Copy link
Contributor

I'm sure I will have time sometime next month.

@ManasJayanth
Copy link
Member

Thanks everyone who worked on this! Looks like this was a collective effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for --dev to esy add
4 participants