Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom tag example #29

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Add custom tag example #29

merged 1 commit into from
Sep 20, 2020

Conversation

trojanh
Copy link
Contributor

@trojanh trojanh commented Sep 18, 2020

Fixes #7

@nebrelbug
Copy link
Collaborator

@trojanh thanks, this looks great!

@nebrelbug nebrelbug merged commit acf2977 into eta-dev:master Sep 20, 2020
@nebrelbug
Copy link
Collaborator

@trojanh do you mind if I add you to the README as a contributor to examples?

@trojanh
Copy link
Contributor Author

trojanh commented Sep 20, 2020

Please go ahead and add me, would be happy to help. Thanks for merging the PR.

@nebrelbug
Copy link
Collaborator

Great! @all-contributors please add @trojanh for examples.

@allcontributors allcontributors bot mentioned this pull request Sep 21, 2020
Merged
@allcontributors
Copy link
Contributor

@nebrelbug

I've put up a pull request to add @trojanh! 🎉

@nebrelbug
Copy link
Collaborator

Thanks @trojanh, just added you!

image

Hope you can contribute more in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complex template not working
2 participants
@trojanh @nebrelbug