Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement org-based write permissions in frontend #441
Implement org-based write permissions in frontend #441
Changes from all commits
53a3586
d25733b
6d6539d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dans ce fichier, je rends les
navigationItems
réactifs par rapport au catalogue de l'utilisateur courant.En effet, quand on se connecte avec un utilisateur dont l'organisation n'a pas de catalogue, le navItem "Contribuer" ne doit pas être visible.
Le besoin d'un
debounce()
me déçoit un peu (ce n'est pas la faute durefresh()
: j'ai essayé de le commenter et sans debounce j'avais 2 requêtes identiques qui se lançaient), j'ai laissé unXXX
pour l'instant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'en ai profité pour simplifier cette utilisation de
projects
en définissant directement une constanteADMIN_PASSWORD
, comme pour le reste.À l'époque, je crois que j'avais fait ça parce qu'on ne pouvait pas vraiment importer du code dans les fichiers dans
tests/e2e
. Avec la dernière version de Playwright ça passe crème.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ici il y avait un bug : on récupérait le SIRET de l'utilisateur courant, mais en fait dans le contexte de l'édition d'un dataset, c'est le catalogue du jeu de données qui nous intéresse !