Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump next from 7.0.1 to 7.0.2 #774

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Oct 15, 2018

Bumps next from 7.0.1 to 7.0.2.

Release notes

Sourced from next's releases.

7.0.2

Release Notes

This upgrade is completely backwards compatible and recommended for all users on version 7.0.0 and 7.0.1
For future security related communications of our OSS projects, please join this mailing list.

Next.js has just been audited by one of the top security firms in the world. They found a XSS vulnerability on /_error pages (404, 500), where an attacker could craft a request that executes client side code on these particular pages. As a reminder, websites that follow OWASP security guidelines should see minimized impact from this attack vector.

How to Upgrade

  • We have released patch versions for both the stable and canary channels of Next.js.
  • The following versions fix this bug and include precautions to avoid
    similar problems in the future
  • Run npm install next@latest --save
  • When using the canary release channel use npm install next@canary --save

Impact

  • Affected: Users of Next.js using version 7.0.0 and 7.0.1
  • Not affected: Deployments on https://now.sh (like https://zeit.co) are mitigated.
  • Not affected: Static deployments via next export

We recommend everyone to upgrade regardless of whether you can reproduce the issue or not.

How to Assess Impact

If you think sensitive code or data could have been exposed, please filter logs of affected sites by /' with a 404 response.

What is Being Done

As Next.js has grown in popularity, it has received the attention of security researchers and auditors. We are thankful to Jessica Stokes from Buildkite, lvh and Jeremy Rauch from Latacora for their investigation and discovery of the original bug and subsequent responsible disclosure.

Next.js 7.0.0 included a bugfix for the inline script generation code, it previously had a condition that would always return false, causing the error page to not be initialized. The generated code passed the pathname through the htmlescape module to escape arbitrary HTML characters. However this module does not escape single quotes ('). Meaning that an attacker could break out of the code block by including extra single quotes in the pathname. In Next.js 7.0.2 we have completely removed the user provided pathname value from the inline script tag. Regression tests for this attack were added to the security test suite.

  • We have notified known Next.js users in advance of this publication.
  • A public CVE was released
  • If you want to stay on top of our security related news impacting Next.js or other ZEIT projects, please join this mailing list.
  • We encourage responsible disclosure of future issues. Please email us at security@zeit.co. We are actively monitoring this mailbox.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will not automatically merge this PR because it includes a patch update to a production dependency.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added the dependencies Issue related to dependencies label Oct 15, 2018
@jdesboeufs jdesboeufs temporarily deployed to geodatagouv-pr-774 October 15, 2018 05:04 Inactive
Bumps [next](https://github.com/zeit/next.js) from 7.0.1 to 7.0.2.
- [Release notes](https://github.com/zeit/next.js/releases)
- [Commits](vercel/next.js@7.0.1...7.0.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@codecov
Copy link

codecov bot commented Oct 15, 2018

Codecov Report

Merging #774 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #774   +/-   ##
======================================
  Coverage    5.36%   5.36%           
======================================
  Files         114     114           
  Lines        1510    1510           
======================================
  Hits           81      81           
  Misses       1429    1429

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af89b3...c97b77c. Read the comment docs.

@buildsize
Copy link

buildsize bot commented Oct 15, 2018

File name Previous Size New Size Change
page-_error.js.gz 185 bytes 185 bytes 0 bytes (0%)
page-catalog.js.gz 56.48 KB 56.48 KB 0 bytes (0%)
page-catalogs.js.gz 3.55 KB 3.55 KB 0 bytes (0%)
page-dataset.js.gz 19.22 KB 19.22 KB 0 bytes (0%)
page-doc-publish-your-data.js.gz 3.7 KB 3.7 KB 0 bytes (0%)
page-doc.js.gz 1.91 KB 1.91 KB 0 bytes (0%)
page-events.js.gz 2.29 KB 2.29 KB 0 bytes (0%)
page-harvest.js.gz 3.04 KB 3.04 KB 0 bytes (0%)
page-index.js.gz 5.76 KB 5.76 KB 0 bytes (0%)
page-legal.js.gz 805 bytes 805 bytes 0 bytes (0%)
page-publication-datasets.js.gz 5.91 KB 5.91 KB 0 bytes (0%)
page-publication-organization.js.gz 10.35 KB 10.35 KB 0 bytes (0%)
page-publication-producers.js.gz 5.38 KB 5.38 KB 0 bytes (0%)
page-publication.js.gz 3.75 KB 3.75 KB 0 bytes (0%)
page-search.js.gz 7.76 KB 7.76 KB 0 bytes (0%)
page-doc-link-proxy.js.gz 1.45 KB 1.45 KB 0 bytes (0%)
page-embed-preview.js.gz 4.73 KB 4.73 KB 0 bytes (0%)
page-_app.js.gz 2.8 KB 2.8 KB 0 bytes (0%)
chunk-centered-map.[hash].js.gz 169.31 KB 169.31 KB 0 bytes (0%)
chunk-commons.[hash].js.gz 125.61 KB 125.61 KB -5 bytes (0%)
chunk-preview-table.[hash].js.gz 12.6 KB 12.6 KB 0 bytes (0%)
runtime-main-[hash].js.gz 1.68 KB 1.68 KB 0 bytes (0%)
runtime-webpack-[hash].js.gz 1.22 KB 1.22 KB 0 bytes (0%)

@tusbar tusbar added this to the 3.8.0 milestone Oct 15, 2018
@tusbar tusbar merged commit d047a66 into master Oct 15, 2018
@tusbar tusbar deleted the dependabot/npm_and_yarn/next-7.0.2 branch October 15, 2018 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issue related to dependencies security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants