This repository has been archived by the owner on Sep 14, 2021. It is now read-only.
Added the missing placeholders #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noirbizarre
requested review from
davidbgk,
abulte,
thom4parisot,
vinyll,
thimy and
teleboas
abulte
reviewed
Jun 26, 2017
|
May be part of a future PR but switching to SVG might be nice. |
|
I totally agree. In a different PR I think, but placeholders are not very explicit |
|
(A Marianne placeholder for user would make sense and is now doable ;)) |
noirbizarre
changed the title
abulte
approved these changes
Jun 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing placeholders.
See also opendatateam/udata#707 and opendatateam/udata#1003 for context