Skip to content
This repository has been archived by the owner on Sep 14, 2021. It is now read-only.

add onSubmit on suggest search input to redirect #612

Merged
merged 4 commits into from
Aug 11, 2021

Conversation

maudetes
Copy link
Contributor

@maudetes maudetes commented Aug 10, 2021

Fix datagouv/data.gouv.fr#371.

Any suggestion for a better pattern is welcome ! :)

Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using the action of the form?

theme/js/components/search/search-input.vue Outdated Show resolved Hide resolved
@maudetes
Copy link
Contributor Author

What about using the action of the form?

I first thought about using action, but we don't particularly want this behavior on /fr/datasets page and I couldn't find a clean way to set these attributes conditionally, I can give it another go !

@abulte
Copy link
Contributor

abulte commented Aug 10, 2021

What about using the action of the form?

I first thought about using action, but we don't particularly want this behavior on /fr/datasets page and I couldn't find a clean way to set these attributes conditionally, I can give it another go !

It's ok, we're in a JS component anyway, so it doesn't really matter, except maybe for a11n, we'll see ;-)

@maudetes maudetes requested a review from abulte August 10, 2021 14:54
@maudetes maudetes merged commit 6b735ca into etalab:master Aug 11, 2021
@maudetes maudetes deleted the enter-dataset-search branch August 11, 2021 06:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pas de renvoi vers la page de recherche sur le suggest lorsqu'on tape la touche Entrée
2 participants