Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accumulated enhancement to etcd-cpp-apiv3. #16

Merged
merged 7 commits into from
Sep 29, 2020

Conversation

sighingnow
Copy link
Member

hi @CsatariGergely ,

I'm so happy to see this repository get updated by the author team! And so many developers that invokes in etcd API benefit from this project.

However this package hasn't been updated since 4 years ago, and we do do a better job to make this project more helpful for C++ developers.

This PR includes our efforts to make the library work for recently version of etcd, c++ compilers, cmake, and provides better experiments for installment and deployment.

Detailedly, this pull request includes:

  • update protobuf definition to latest version in etcd repo
  • better cmake integration, includes:
    • generate protobuf files on-modify to accelebrate building process
    • better facilities to install etcd-cpp-apiv3 as a "package" that could be found by on-top programs.
  • implements the etcd "lock" api
  • fixes bugs in the "WatchAction"
  • load balance (in gRPC) over multiple etcd endpoints.

Since this project is the recommanded way to connect to etcd in C++ on the etcd website, I'm looking forward to getting this PR merged and help more people. If you have any question about getting this one merge, feel to let me know.

Best regards,
Tao

@sighingnow
Copy link
Member Author

Besides, if it is possbile I'm very interested in co-maintainning this project :)

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant