Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the implementation of Observe() #231

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

sighingnow
Copy link
Member

Fixes #224 by

  • Fixes the extra Read() as we only support WaitOnce().
  • Fixes the behavior of CancelObserve().
  • Add a test case and revisit the example README.

Signed-off-by: Tao He <sighingnow@gmail.com>
@sighingnow sighingnow merged commit 32fae70 into etcd-cpp-apiv3:master Jul 1, 2023
6 checks passed
@sighingnow sighingnow deleted the ht/fix-election branch July 1, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

call API observe more than once will lead to crash
1 participant