Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes compiler errors #254

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

Diskein
Copy link
Contributor

@Diskein Diskein commented Oct 3, 2023

Hi,

I was compiled it from the scratch with gcc (Debian 12.2.0-14) 12.2.0 with -Wall enabled and I got some error:

/opt/src/thirdparty/etcd-cpp-apiv3/src/KeepAlive.cpp:72:52: error: unused parameter 'handler' [-Werror=unused-parameter]
   72 |     std::function<void(std::exception_ptr)> const& handler, int ttl,
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
/opt/src/thirdparty/etcd-cpp-apiv3/src/SyncClient.cpp:150:1: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
  150 | const bool authenticate(std::shared_ptr<grpc::Channel> const& channel,  

The first one is an actual error that can lead to bugs if the ctor will be used. The handler passed to the ctor was omitted by mistake.

Denis Kalantaevsky added 2 commits October 3, 2023 12:47
src/SyncClient.cpp Outdated Show resolved Hide resolved
@sighingnow sighingnow merged commit 5963500 into etcd-cpp-apiv3:master Oct 6, 2023
6 checks passed
@sighingnow
Copy link
Member

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants