Skip to content

Commit

Permalink
tests/e2e: add comments that desired behavior after all the readyz/li…
Browse files Browse the repository at this point in the history
…vez checks are implemented

Signed-off-by: Chao Chen <chaochn@amazon.com>
  • Loading branch information
chaochn47 committed Oct 26, 2023
1 parent 46b226f commit 15ae6f0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/e2e/http_health_check_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ func TestHTTPLivezReadyzHandler(t *testing.T) {
},
{
url: "/readyz",
expectedStatusCode: http.StatusOK,
expectedStatusCode: http.StatusOK, // TODO expected behavior should be 503 or timeout after ReadIndex check is implemented.
},
},
},
Expand All @@ -240,11 +240,11 @@ func TestHTTPLivezReadyzHandler(t *testing.T) {
// ref. https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/phases/etcd/local.go#L225-L226
// current liveness probe depends on the etcd /health check has a flaw that new /livez check should resolve.
url: "/livez",
expectedStatusCode: http.StatusOK,
expectedStatusCode: http.StatusOK, // TODO expected behavior should be 503 or timeout after RaftLoopDeadLock check is implemented.
},
{
url: "/readyz",
expectedStatusCode: http.StatusOK,
expectedStatusCode: http.StatusOK, // TODO expected behavior should be 503 or timeout after ReadIndex check is implemented.
},
},
},
Expand Down

0 comments on commit 15ae6f0

Please sign in to comment.