Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go.etcd.io/etcd versioned import path #11820

Closed
4 tasks done
philips opened this issue Apr 26, 2020 · 3 comments · Fixed by #11823
Closed
4 tasks done

fix go.etcd.io/etcd versioned import path #11820

philips opened this issue Apr 26, 2020 · 3 comments · Fixed by #11823

Comments

@philips
Copy link
Contributor

philips commented Apr 26, 2020

There are other bugs related to this but I am trying to summarize the issue, history of why this was rolled back, and how to fix it.

Problem:

etcd is currently incompatible with the Go module versioning. This is an example using go1.14.2:

$ go mod init test-etcd-client/v3
$ go get go.etcd.io/etcd/clientv3@v3.4.7
go get go.etcd.io/etcd/clientv3@v3.4.7: go.etcd.io/etcd@v3.4.7: invalid version: module contains a go.mod file,
so major version must be compatible: should be 
v0 or v1, not v3

Why is this important?

  • Go ecosystem developer workflows are broken (see above)
  • https://pkg.go.dev/go.etcd.io/etcd?tab=doc doesn’t default to the latest release
  • Go mod versioning features are defaulting to on in go1.14 which may cause additional when we move past go1.13 as our default; might as well figure it out now

What needs to be checked

  • Is etcd using a version of go with go modules now? (Yes, go1.13)
  • Update all docs to point to the new package
  • ...?

Side effects that need investigation

Unavoidable Side Effects

Paths forward

@purpleidea
Copy link
Contributor

Remove go.mod

Please do this. It's unhelpful to have go mod IMHO... vendor/ worked great before. I know I'm probably in the minority to say it, but go.mod has caused more problems than it solved. Happy to discuss more if it would help you.

@gyuho
Copy link
Contributor

gyuho commented Apr 26, 2020

Last attempted here #11349. Proto gen was not working...

If anybody can help, it will be greatly appreciated!

@philips
Copy link
Contributor Author

philips commented Apr 28, 2020

PR ready for merging, I think #11823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants