Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: rename import paths to "go.etcd.io/etcd" #10044

Merged
merged 21 commits into from Aug 29, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Aug 29, 2018

Fix #9965.

This only updates the necessary ones to wrap up our github org migration. Some still reference to github.com/coreos/etcd (e.g. v2 docs, old branches). Will change rest in the following PR.

Note: this does not add canonical import paths (https://golang.org/doc/go1.4#canonicalimports), which I don't think is necessary--Kubernetes does not use it either.

/cc @philips @xiang90 @jpbetz

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
Copy link
Contributor Author

gyuho commented Aug 29, 2018

Proto gen has some issues with swagger doc... Will debug separate. Reverted the change for now.

@gyuho gyuho added the WIP label Aug 29, 2018
@philips
Copy link
Contributor

philips commented Aug 29, 2018

LGTM

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho gyuho removed the WIP label Aug 29, 2018
@gyuho gyuho merged commit e8b940f into etcd-io:master Aug 29, 2018
@gyuho gyuho deleted the rename-import-paths branch August 29, 2018 02:44
@vimalk78
Copy link
Contributor

whats the effect on developers?
just do a fresh git clone or go get from github.com/etcd-io/etcd and add remotes newly?
or there is a go specific way to move the project from one path to another

@gyuho
Copy link
Contributor Author

gyuho commented Aug 29, 2018

You can just move git to ${GOPATH}/src/go.etcd.io/etcd, and sync with upstream master branch.

@philips
Copy link
Contributor

philips commented Aug 29, 2018

@jpbetz Aside: the preferred pkg prefix going forward should be go.etcd.io/etcd

@jpbetz
Copy link
Contributor

jpbetz commented Aug 29, 2018

Thanks @philips I'll update the above comment to match.

@jingyih
Copy link
Contributor

jingyih commented Aug 29, 2018

Thanks @jpbetz for the detailed explanation and suggested fix. I think we should make this more visible to the etcd community.

@khenaidoo
Copy link

@jpbetz Thanks for the detailed explanation. This is exactly the issue I was having. I don't have a dependency on etcd master, so I can use a release version. Since we will eventually have to handle newer etcd releases, for now, I will move to go.etcd.io/etcd and give it a try.

Thanks
Khen

wolfeidau pushed a commit to wolfeidau/valkeyrie that referenced this pull request Oct 17, 2018
wolfeidau pushed a commit to wolfeidau/valkeyrie that referenced this pull request Oct 17, 2018
wolfeidau pushed a commit to wolfeidau/valkeyrie that referenced this pull request Oct 18, 2018
* Fix boltdb import -> go.etcd.io/bbolt
* Fix etcd import -> go.etcd.io/etcd

etcd-io/etcd#10044 (comment)
wolfeidau pushed a commit to wolfeidau/valkeyrie that referenced this pull request Oct 18, 2018
* Fix boltdb import -> go.etcd.io/bbolt
* Fix etcd import -> go.etcd.io/etcd
* Bumped underlying service versions in build
* Bumped the golang version
* Fix for golint

etcd-io/etcd#10044 (comment)
@ueokande ueokande mentioned this pull request Nov 10, 2018
@lei314121077
Copy link

lei314121077 commented Dec 3, 2018

why i import this package is this error?

github.com/etcd-io/etcd/clientv3

../src/github.com/etcd-io/etcd/clientv3/auth.go:116:72: cannot use auth.callOpts (type []"github.com/etcd-io/etcd/vendor/google.golang.org/grpc".CallOption) as type []"go.etcd.io/etcd/vendor/google.golang.org/grpc".CallOption in argument to auth.remote.AuthEnable
../src/github.com/etcd-io/etcd/clientv3/auth.go:121:74: cannot use auth.callOpts (type []"github.com/etcd-io/etcd/vendor/google.golang.org/grpc".CallOption) as type []"go.etcd.io/etcd/vendor/google.golang.org/grpc".CallOption in argument to auth.remote.AuthDisable
../src/github.com/etcd-io/etcd/clientv3/auth.go:126:100: cannot use auth.callOpts (type []"github.com/etcd-io/etcd/vendor/google.golang.org/grpc".CallOption) as type []"go.etcd.io/etcd/vendor/google.golang.org/grpc".CallOption in argument to auth.remote.UserAdd
../src/github.com/etcd-io/etcd/clientv3/auth.go:131:86: cannot use auth.callOpts (type []"github.com/etcd-io/etcd/vendor/google.golang.org/grpc".CallOption) as type []"go.etcd.io/etcd/vendor/google.golang.org/grpc".CallOption in argument to auth.remote.UserDelete
../src/github.com/etcd-io/etcd/clientv3/auth.go:136:122: cannot use auth.callOpts (type []"github.com/etcd-io/etcd/vendor/google.golang.org/grpc".CallOption) as type []"go.etcd.io/etcd/vendor/google.golang.org/grpc".CallOption in argument to auth.remote.UserChangePassword
../src/github.com/etcd-io/etcd/clientv3/auth.go:141:104: cannot use auth.callOpts (type []"github.com/etcd-io/etcd/vendor/google.golang.org/grpc".CallOption) as type []"go.etcd.io/etcd/vendor/google.golang.org/grpc".CallOption in argument to auth.remote.UserGrantRole
../src/github.com/etcd-io/etcd/clientv3/auth.go:146:80: cannot use auth.callOpts (type []"github.com/etcd-io/etcd/vendor/google.golang.org/grpc".CallOption) as type []"go.etcd.io/etcd/vendor/google.golang.org/grpc".CallOption in argument to auth.remote.UserGet
../src/github.com/etcd-io/etcd/clientv3/auth.go:151:72: cannot use auth.callOpts (type []"github.com/etcd-io/etcd/vendor/google.golang.org/grpc".CallOption) as type []"go.etcd.io/etcd/vendor/google.golang.org/grpc".CallOption in argument to auth.remote.UserList
../src/github.com/etcd-io/etcd/clientv3/auth.go:156:106: cannot use auth.callOpts (type []"github.com/etcd-io/etcd/vendor/google.golang.org/grpc".CallOption) as type []"go.etcd.io/etcd/vendor/google.golang.org/grpc".CallOption in argument to auth.remote.UserRevokeRole
../src/github.com/etcd-io/etcd/clientv3/auth.go:161:80: cannot use auth.callOpts (type []"github.com/etcd-io/etcd/vendor/google.golang.org/grpc".CallOption) as type []"go.etcd.io/etcd/vendor/google.golang.org/grpc".CallOption in argument to auth.remote.RoleAdd
../src/github.com/etcd-io/etcd/clientv3/auth.go:161:80: too many errors

@lei314121077
Copy link

lei314121077 commented Dec 3, 2018

i'm import this package "go.etcd.io/etcd/clientv3" is this panic error ?
I tried to do it. rm -f ....../src/go.etcd.io/etcd/vendor/golang.org/x/net/trace/trace.go but invalid!

panic: /debug/requests is already registered. You may have two independent copies of golang.org/x/net/trace in your binary, trying to maintain separate state. This may involve a vendored copy of golang.org/x/net/trace.

goroutine 1 [running]:
go.etcd.io/etcd/vendor/golang.org/x/net/trace.init.0()
....../src/go.etcd.io/etcd/vendor/golang.org/x/net/trace/trace.go:116 +0x14a
exit status 2

mhausenblas added a commit to mhausenblas/reshifter that referenced this pull request Dec 6, 2018
tinx added a commit to tinx/distlock that referenced this pull request Jan 31, 2019
The etcd project has switched from github.com URLs to
go.etcd.io URLs. The import statements in distlock.go
have been updated to reflect this. The old imports
failed to compile. See here for details:
etcd-io/etcd#10044 (comment)
ldez pushed a commit to kvtools/boltdb that referenced this pull request Sep 8, 2022
* Fix boltdb import -> go.etcd.io/bbolt
* Fix etcd import -> go.etcd.io/etcd
* Bumped underlying service versions in build
* Bumped the golang version
* Fix for golint

etcd-io/etcd#10044 (comment)
ldez pushed a commit to kvtools/etcdv3 that referenced this pull request Sep 8, 2022
* Fix boltdb import -> go.etcd.io/bbolt
* Fix etcd import -> go.etcd.io/etcd
* Bumped underlying service versions in build
* Bumped the golang version
* Fix for golint

etcd-io/etcd#10044 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants