clientv3: let etcd client use all available keepalive ClientParams #10146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spzala Could you also update changelog? Thanks! |
|
@gyuho, hi, thanks! Sure, should I update a particular one i.e. changlog-3.4? I was thinking to update here https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.4.md#client-v3 but thought let me make sure with you first. Thanks! |
|
@spzala Yes, we should update v3.4 changelog. |
We should allow etcd client use all of the available keepalive client parameters as documented in this link, https://godoc.org/google.golang.org/grpc/keepalive#ClientParameters Currently in the etcd, by default PermitWithoutStream is set to false, and user has no way to override it. On the server side, we explicitely setting EnforcementPolicy PermitWithoutStream to false and don't provide option to override it to user but on the client side we should allow this option as provided by the grpc.
spzala
force-pushed
the
clientpermitwithoutstream
branch
from
c800883
to
f6f3751
Compare
|
@gyuho thanks!! Updated it. |
gyuho
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should allow etcd client use all of the available keepalive
client parameters as documented in this link,
https://godoc.org/google.golang.org/grpc/keepalive#ClientParameters
Currently in the etcd, by default PermitWithoutStream is set to
false, and user has no way to override it.
On the server side, we explicitely setting EnforcementPolicy
PermitWithoutStream to false and don't provide option to override it
to user but on the client side we should allow this option as
provided by the grpc.