etcdserver: clear message in cluster version decision #10159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10159 +/- ##
==========================================
- Coverage 71.5% 71.44% -0.07%
==========================================
Files 390 390
Lines 36306 36306
==========================================
- Hits 25962 25940 -22
- Misses 8524 8536 +12
- Partials 1820 1830 +10
Continue to review full report at Codecov.
|
xiang90
reviewed
Oct 8, 2018
etcdserver/cluster_util.go
Outdated
| @@ -203,7 +203,7 @@ func decideClusterVersion(lg *zap.Logger, vers map[string]*version.Versions) *se | |||
| if lv.LessThan(*v) { | |||
| if lg != nil { | |||
| lg.Warn( | |||
| "local etcd version is not up-to-date", | |||
| "leader found higher-versioned peer", | |||
There was a problem hiding this comment.
higher-visioned member. we only use peer in raft layer.
There was a problem hiding this comment.
zap.String also needs to be fixed.
Only leader can decide cluster version. Clarify the logging that this local node is the leader. Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only leader can decide cluster version.
Clarify the logging that this local node is the leader.
Signed-off-by: Gyuho Lee leegyuho@amazon.com