Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver/*: add "etcd_cluster_version" metric #10257

Merged
merged 2 commits into from
Nov 15, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Nov 14, 2018

This will be useful for #7308 (rollback support).

We can monitor local etcd_cluster_version metrics from each node, to decide whether the downgrade/upgrade target version has been agreed.

/cc @wenjiaswe @jpbetz

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@xiang90
Copy link
Contributor

xiang90 commented Nov 15, 2018

lgtm

@xiang90 xiang90 merged commit 024f3df into etcd-io:master Nov 15, 2018
@gyuho gyuho deleted the cluster-version branch November 15, 2018 16:16
@wenjiaswe
Copy link
Contributor

Thank you very much @gyuho !

gyuho added a commit that referenced this pull request Oct 17, 2019
…257-upstream-release-3.3

cherry pick "etcd_cluster_version" metric" (#10257, #11233, #11254, #11265) to release-3.3
gyuho added a commit that referenced this pull request Oct 17, 2019
…261-upstream-release-3.2

cherry pick "etcd_cluster_version" metric" (#10257, #11233, #11254, #11265) to release-3.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants