etcdserver: strip patch version in cluster version metrics

[jingyih]

@gyuho We discussed about stripping patch version in cluster version metrics.

Example output:

# TYPE etcd_cluster_version gauge
etcd_cluster_version{cluster_version="3.5"} 1

[gyuho]

lgtm

[gyuho]

@jpbetz @jingyih I think we can backport this to 3.4, as long as we highlight the change. What do you think? Including patch version in cluster version is very confusing anyways.

[gyuho]

@jingyih Looks like some e2e tests are breaking from this change?

[jingyih]

I am in favor of backporting to 3.4.

e2e metrics test failed due to this change, I will fix it.

[gyuho]

lgtm, yes then let's backport.

[jpbetz]

The patch version was always 0 before this anyway, right? Just making sure I understand.

[jingyih]

The patch version was always 0 before this anyway, right? Just making sure I understand.

This is also my understanding.

Also, in the log output we never included patch version in cluster version.

etcd/etcdserver/api/membership/cluster.go

Line 271 in bcc1471

zap.String("cluster-version", version.Cluster(c.version.String())),

[jpbetz]

Great. Thanks for fixing.

…

On Mon, Oct 14, 2019 at 5:57 PM Jingyi Hu ***@***.***> wrote: The patch version was always 0 before this anyway, right? Just making sure I understand. This is also my understanding. Also, in the log output we never included patch version in cluster version. https://github.com/etcd-io/etcd/blob/bcc147127d1a33d827f78a0d1bf8fe2363a344f2/etcdserver/api/membership/cluster.go#L271 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11254?email_source=notifications&email_token=AAD72RXTXE3W5NH2NKKMANLQOUIPZA5CNFSM4JAT3LD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBHBXIQ#issuecomment-541989794>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD72RT5UAT2ILJQ56ZCDXTQOUIPZANCNFSM4JAT3LDQ> .