New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP *: bump up default Go runtime for tests #10441
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10441 +/- ##
==========================================
- Coverage 71.61% 71.43% -0.18%
==========================================
Files 392 391 -1
Lines 36489 36472 -17
==========================================
- Hits 26131 26055 -76
- Misses 8531 8588 +57
- Partials 1827 1829 +2
Continue to review full report at Codecov.
|
lgtm |
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Deprecated, in favor of "staticcheck" Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gyuho hi, should not we remove these two references as well?
gosimple - https://github.com/etcd-io/etcd/blob/master/tests/Dockerfile#L52
unused - https://github.com/etcd-io/etcd/blob/master/tests/Dockerfile#L53
Already uploaded to gcr.io.
For #10438.
/cc @xiang90 @jpbetz @hexfusion
Will do the patch release next week.