Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP *: bump up default Go runtime for tests #10441

Closed
wants to merge 8 commits into from

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Feb 1, 2019

Already uploaded to gcr.io.

For #10438.

/cc @xiang90 @jpbetz @hexfusion

Will do the patch release next week.

@codecov-io
Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #10441 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10441      +/-   ##
==========================================
- Coverage   71.61%   71.43%   -0.18%     
==========================================
  Files         392      391       -1     
  Lines       36489    36472      -17     
==========================================
- Hits        26131    26055      -76     
- Misses       8531     8588      +57     
- Partials     1827     1829       +2
Impacted Files Coverage Δ
clientv3/retry.go 87.27% <ø> (ø) ⬆️
clientv3/retry_interceptor.go 67.2% <ø> (+1.41%) ⬆️
clientv3/client.go 80% <ø> (+1.12%) ⬆️
clientv3/balancer/grpc1.7-health.go 46.22% <0%> (-13.67%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-11.12%) ⬇️
clientv3/leasing/util.go 91.66% <0%> (-6.67%) ⬇️
pkg/adt/interval_tree.go 79.87% <0%> (-6.61%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
etcdserver/v2_server.go 80.76% <0%> (-3.85%) ⬇️
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0f0ba...29d4304. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Feb 1, 2019

lgtm

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Deprecated, in favor of "staticcheck"

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho gyuho changed the title *: bump up default Go runtime for tests WIP *: bump up default Go runtime for tests Feb 7, 2019
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spzala spzala mentioned this pull request Apr 10, 2019
@spzala
Copy link
Member

spzala commented Apr 11, 2019

@gyuho I have fetched this PR in my env, made couple of changes and pushed it under #10631 Hope makes sense. I will keep this PR open as WIP but will close eventually in favor of the new PR.
@xiang90 you already have a lgtm on this PR so can you please take a look at the #10631 :-) Thanks!

@xiang90
Copy link
Contributor

xiang90 commented Jun 11, 2019

this is already fixed by @spzala right? /cc @gyuho

@gyuho gyuho closed this Jun 13, 2019
@gyuho
Copy link
Contributor Author

gyuho commented Jun 13, 2019

@spzala @xiang90 Yes, right. Thanks!

@gyuho gyuho deleted the go-runtime branch June 13, 2019 17:04
@spzala
Copy link
Member

spzala commented Jun 13, 2019

Thanks @xiang90 @gyuho - I have also closed couple of other related issues.

@spzala
Copy link
Member

spzala commented Jun 13, 2019

this is already fixed by @spzala right? /cc @gyuho

@xiang90 sorry for the delayed response due to vacation travel :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants