Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update to Go 1.12.2 #10619

Closed
wants to merge 1 commit into from
Closed

*: update to Go 1.12.2 #10619

wants to merge 1 commit into from

Conversation

spzala
Copy link
Member

@spzala spzala commented Apr 5, 2019

Update to go 1.12.2 testing.

Fixes #10528

@spzala spzala requested review from gyuho and hexfusion April 5, 2019 19:59
@spzala spzala added the WIP label Apr 5, 2019
@@ -6,7 +6,7 @@ sudo: required
services: docker

go:
- 1.11.4
- 1.12
- tip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be explicitly 1.12.2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @hexfusion

Update to go 1.12.2 testing.

Fixes etcd-io#10528
@spzala
Copy link
Member Author

spzala commented Apr 6, 2019

@hexfusion @gyuho I don't see any issue with build, format or unit test in my env. Thanks!

@spzala spzala changed the title *: update to Go 1.12 *: update to Go 1.12.2 Apr 6, 2019
@gyuho
Copy link
Contributor

gyuho commented Apr 8, 2019

Did we build and push the Go 1.12 based test image?

@spzala
Copy link
Member Author

spzala commented Apr 8, 2019

Did we build and push the Go 1.12 based test image?

@gyuho nope, not yet. That's where @hexfusion needs to help out :-)

@hexfusion
Copy link
Contributor

@spzala thanks for your patience test image is up

@spzala spzala closed this Apr 9, 2019
@spzala spzala reopened this Apr 9, 2019
@spzala
Copy link
Member Author

spzala commented Apr 9, 2019

@spzala
Copy link
Member Author

spzala commented Apr 10, 2019

The failure I see in build is fmt related and this error
gosimple checking failed: Gosimple has been deprecated. Please use staticcheck instead. @gyuho already have patch #10441 under review to remove deprecated packages with staticcheck. Hopping that PR should take care of the failure here..is there anything holding for that PR to be merged? I have one review comment there. Thanks!

@philips philips mentioned this pull request Apr 10, 2019
@gyuho
Copy link
Contributor

gyuho commented Apr 10, 2019

@spzala Can you take over #10441?

@spzala
Copy link
Member Author

spzala commented Apr 10, 2019

@spzala Can you take over #10441?

@gyuho thanks and sure that sounds good! I am at a local conference in Raleigh today all day but will get back to work soon :-)

@spzala
Copy link
Member Author

spzala commented Apr 11, 2019

@gyuho @hexfusion I have created #10631 (merged this PR and #10441) I will keep this PR open as WIP but will close eventually in favor of the new PR if that makes sense. Thanks!

@spzala spzala removed the WIP label Jun 4, 2019
@spzala
Copy link
Member Author

spzala commented Jun 4, 2019

@gyuho @hexfusion closing this one since we have Go 1.12.5 update in place under #10766 and we are doing test related updates in another PR as mentioned above. Thanks!

@spzala spzala closed this Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Go 1.12 (tests)
3 participants