Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/raftexample: add test for httpKVAPI. #10557

Merged
merged 1 commit into from
Mar 28, 2019
Merged

contrib/raftexample: add test for httpKVAPI. #10557

merged 1 commit into from
Mar 28, 2019

Conversation

johncming
Copy link
Contributor

add a testcase for httpKVAPI which is an import component in raftexample.

In addition, it is helpful to solve problem like #10361.

@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #10557 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10557      +/-   ##
==========================================
+ Coverage   71.77%   71.81%   +0.04%     
==========================================
  Files         393      393              
  Lines       36573    36573              
==========================================
+ Hits        26249    26266      +17     
+ Misses       8496     8487       -9     
+ Partials     1828     1820       -8
Impacted Files Coverage Δ
proxy/grpcproxy/watch.go 88.55% <0%> (-4.22%) ⬇️
clientv3/balancer/balancer.go 84.49% <0%> (-2.33%) ⬇️
etcdserver/api/membership/cluster.go 77.5% <0%> (-2.05%) ⬇️
pkg/adt/interval_tree.go 88.58% <0%> (-1.81%) ⬇️
pkg/netutil/netutil.go 69.67% <0%> (-0.82%) ⬇️
etcdserver/server.go 74.82% <0%> (+0.07%) ⬆️
mvcc/watchable_store.go 84.91% <0%> (+0.35%) ⬆️
etcdserver/api/rafthttp/stream.go 79.82% <0%> (+0.42%) ⬆️
clientv3/leasing/kv.go 90.36% <0%> (+0.66%) ⬆️
etcdserver/v3_server.go 79.54% <0%> (+0.68%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ca3b4...51cdbb6. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Mar 28, 2019

lgtm

@xiang90 xiang90 merged commit d5e94b1 into etcd-io:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants