Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go get cmd #12430

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Fix go get cmd #12430

merged 1 commit into from
Nov 3, 2020

Conversation

meadlai
Copy link
Contributor

@meadlai meadlai commented Oct 28, 2020

Fix go get CMD for client

ptabor
ptabor approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@ptabor ptabor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing.

Please change the commit (not PR) title to:

"client: Update README.md"

to have the tests PASS

spzala
spzala approved these changes Oct 29, 2020
View reviewed changes
client/v3/README.md
@@ -8,7 +8,7 @@
## Install

```bash
go get go.etcd.io/etcd/clientv3
go get go.etcd.io/etcd/client/v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@meadlai thanks, as @ptabor mentioned, please update commit title.

@xiang90
Copy link
Contributor

xiang90 commented Oct 29, 2020

@ptabor

As we have more and more new comers contributing to etcd project, I feel we should just remove the strict commit title style requirement. As long as the commit title is clear, we should just merge it.

Do you agree? Can you help to remove the check? /cc @gyuho

@ptabor
Copy link
Contributor

ptabor commented Oct 30, 2020

@ptabor

As we have more and more new comers contributing to etcd project, I feel we should just remove the strict commit title style requirement. As long as the commit title is clear, we should just merge it.

Do you agree? Can you help to remove the check? /cc @gyuho

Will do. ETA: Mon.

@ptabor ptabor mentioned this pull request Nov 3, 2020
Merged
@jingyih jingyih merged commit cd09726 into etcd-io:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spzala spzala spzala approved these changes

@ptabor ptabor ptabor approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meadlai @xiang90 @ptabor @spzala @jingyih