Clarify the root directory comment #12659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A contributor had an issue when ran script changing the directory name after clone. This was discussed on the etcd slack channel.
|
/cc @nate-double-u |
|
Slack thread link: https://kubernetes.slack.com/archives/C3HD8ARJ5/p1611945997006900 |
Not only if the folder name is changed after cloning -- if you fork the repo and rename it, then clone that renamed fork, it'll run into the same problem. An admittedly infrequent event I think. The problem is that the |
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
| # | |||
| # Generate all etcd protobuf bindings. | |||
| # Run from repository root. | |||
| # Run from repository root directory named etcd. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A contributor had an issue when ran script changing the directory
name after clone. This was discussed on the etcd slack channel.