Makefile, build.sh: Fix build process #12878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Dockerfile files are now per arch, this adjusts to detect ARCH and builds docker release from the Dockerfile.<ARCH> file.
This fixes so that the ENV vars are taken in the same way as for etcd binary.
ptabor
approved these changes
Apr 19, 2021
gyuho
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
build-docker-release-mastersince the Dockerfile files are now per arch, this adjusts to detect ARCH and builds docker release from the Dockerfile. file.I also ran into an issue while running
make build, that theGO_BUILD_ENVwere not taken into account during build ofetcdctl, this now fixes so that theGO_BUILD_ENVvars are done in the same way as foretcdbinary build step.