-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Refactor spawn json command #14029
Conversation
LGTM. The e2e test failures in the CI are limited to
The missing "header" line where spawn json cmd expects is due to Lines 71 to 75 in b7be91f
the same as I called out in #14020 (comment) So changing etcd/tests/framework/e2e/etcdctl.go Line 555 in 066e510
Should fix the test failures. Or we leave the test lease interface implementation alone. |
I reran the failed pipelines 3 times, but always failing. Please make sure the failures are not caused by this PR or some recent PRs. If the lease issue (the fields are not under the "header") is the reason for the failure, then why some other PRs (i.e. 14022 ) are all green? |
Because other PRs checks etcd/tests/framework/e2e/etcdctl.go Line 353 in 066e510
|
Thanks for the clarification. Then the failure is indeed caused by this PR. We can leave the |
Codecov Report
@@ Coverage Diff @@
## main #14029 +/- ##
==========================================
- Coverage 74.99% 74.80% -0.20%
==========================================
Files 450 450
Lines 37173 37170 -3
==========================================
- Hits 27879 27806 -73
- Misses 7520 7582 +62
- Partials 1774 1782 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0767122
to
bea4665
Compare
743c4d4
to
beac3fe
Compare
beac3fe
to
ac432cf
Compare
ac432cf
to
83a4309
Compare
cc @chaochn47 @ahrtr